Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call CheckMnbAndUpdateMasternodeList when starting MN #1945

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Call CheckMnbAndUpdateMasternodeList when starting MN #1945

merged 2 commits into from
Feb 21, 2018

Conversation

codablock
Copy link

Otherwise the invoking node won't have nCollateralMinConfBlockHash
updated correctly, resulting in the MN showing up in the wrong position
when masternode ranks are calculated.

@codablock
Call CheckMnbAndUpdateMasternodeList when when starting MN
abaa384 
Otherwise the invoking node won't have nCollateralMinConfBlockHash
updated correctly, resulting in the MN showing up in the wrong position
when masternode ranks are calculated.
@UdjinM6
Copy link

UdjinM6 commented Feb 20, 2018

I was trying to remember why we had UpdateMasternodeList for rpc/gui only in the first place and IIRC CheckMnbAndUpdateMasternodeList was too slow for MNOs with huge number of MNs back then. This should no longer be the case AFAIK, so I think we should probably get rid of UpdateMasternodeList completely and replace all of its occurrences with CheckMnbAndUpdateMasternodeList for consistency sake while we are at it (there is one in masternodebroadcast relay rpc and two more in qt/masternodelist.cpp)

@UdjinM6 UdjinM6 added this to the 12.3 milestone Feb 20, 2018
@codablock
Copy link
Author

Added a commit on top to get rid of UpdateMasternodeList completely

@UdjinM6 UdjinM6 changed the title Call CheckMnbAndUpdateMasternodeList when when starting MN Call CheckMnbAndUpdateMasternodeList when starting MN Feb 21, 2018
UdjinM6
UdjinM6 approved these changes Feb 21, 2018
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@UdjinM6 UdjinM6 merged commit 0abd189 into dashpay:develop Feb 21, 2018
@codablock codablock deleted the pr_fix_mn_start branch September 14, 2018 12:49
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@codablock @andvgal
Call CheckMnbAndUpdateMasternodeList when starting MN (dashpay#1945)
4beb5c1 
* Call CheckMnbAndUpdateMasternodeList when when starting MN

Otherwise the invoking node won't have nCollateralMinConfBlockHash
updated correctly, resulting in the MN showing up in the wrong position
when masternode ranks are calculated.

* Remove UpdateMasternodeList and remaining uses of it
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 28, 2019
@codablock @CryptoCentric
Call CheckMnbAndUpdateMasternodeList when starting MN (dashpay#1945)
55a0e9c 
* Call CheckMnbAndUpdateMasternodeList when when starting MN

Otherwise the invoking node won't have nCollateralMinConfBlockHash
updated correctly, resulting in the MN showing up in the wrong position
when masternode ranks are calculated.

* Remove UpdateMasternodeList and remaining uses of it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.3
Development

Successfully merging this pull request may close these issues.
2 participants
@codablock @UdjinM6