Fix recently introduced PS bugs #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarley
reviewed
Oct 9, 2018
| @@ -35,7 +35,14 @@ bool CDarkSendEntry::AddScriptSig(const CTxIn& txin) | |||
|
|
|||
| uint256 CDarksendQueue::GetSignatureHash() const | |||
| { | |||
| return SerializeHash(*this); | |||
| // Remove after migration to 70211 | |||
| { | |||
There was a problem hiding this comment.
What is the reason for the braces / limiting scope here?
There was a problem hiding this comment.
To make it look really annoying so that we wouldn't forget about removing it later :D
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
May 21, 2019
* backward compatibility fix for dsq * fix StartNewQueue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs introduced in #1921 and #2259
Note: e3aef41 should be reverted later ( #2318 is a good place for it, will rebase/fix after this one is merged) but I still want to merge these changes here to have some specific commit in
developwith mixing correctly working on 70210 MNs.