Backport Wallet refactoring and external wallet files 11687 and 13017 #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PastaPastaPasta
force-pushed
the
backport-11687
branch
from
efd0185 to
e458e2c
Compare
|
This breaks auto-backup functionality, need some advise regarding that |
PastaPastaPasta
force-pushed
the
backport-11687
branch
from
e458e2c to
27cac23
Compare
PastaPastaPasta
changed the title
UdjinM6
requested changes
Apr 23, 2020
There was a problem hiding this comment.
Looks good, just one small issue in docs + pls see 450954d for the autobackup fix (I tested it a bit starting with different/multiple wallets and mixing, seems to be working as expected on my mac but pls test it on more systems if you can).
PastaPastaPasta
force-pushed
the
backport-11687
branch
from
6096b3a to
87068fe
Compare
thephez
reviewed
Apr 23, 2020
|
@UdjinM6 starting dashcore |
3c058fd wallet: Add HasWallets (João Barbosa) 373aee2 wallet: Add AddWallet, RemoveWallet, GetWallet and GetWallets (João Barbosa) 6efd964 refactor: Drop CWalletRef typedef (João Barbosa) Pull request description: This is a small step towards dynamic wallet load/unload. The wallets *registry* `vpwallets` is used in several places. With these new functions all `vpwallets` usage are removed and `vpwallets` is now a static variable (no external linkage). The typedef `CWalletRef` is also removed as it is narrowly used. Tree-SHA512: 2ea19da2e17b521ad678bfe10f3257e497ccaf7ab9fd0b6647f9d829f1d6131cfa68db8e8492421711c6da399859432b963a568bdd4ca40a77dd95b597839423
Signed-off-by: pasta <pasta@dashboost.org>
be8ab7d Create new wallet databases as directories rather than files (Russell Yanofsky) 26c06f2 Allow wallet files not in -walletdir directory (Russell Yanofsky) d8a99f6 Allow wallet files in multiple directories (Russell Yanofsky) Pull request description: This change consists of three commits: * The first commit is a pure refactoring that removes the restriction that two wallets can only be opened at the same time if they are contained in the same directory. * The second commit removes the restriction that `-wallet` filenames can only refer to files in the `-walletdir` directory. * The third commit makes second commit a little safer by changing bitcoin to create wallet databases as directories rather than files, so they can be safely backed up. All three commits should be straightforward: * The first commit adds around 20 lines of new code and then updates a bunch of function signatures (generally updating them to take plain fs::path parameters, instead of combinations of strings, fs::paths, and objects like CDBEnv and CWalletDBWrapper). * The second commit removes two `-wallet` filename checks and adds some test cases to the multiwallet unit test. * The third commit just changes the mapping from specified wallet paths to bdb environment & data paths. --- **Note:** For anybody looking at this PR for the first time, I think you can skip the comments before _20 Nov_ and start reading at bitcoin#11687 (comment). Comments before _20 Nov_ were about an earlier version of the PR that didn't include the third commit, and then confusion from not seeing the first commit. Tree-SHA512: 00bbb120fe0df847cf57014f75f1f7f1f58b0b62fa0b3adab4560163ebdfe06ccdfff33b4231693f03c5dc23601cb41954a07bcea9a4919c8d42f7d62bcf6024
Signed-off-by: Pasta <pasta@dashboost.org>
Signed-off-by: Pasta <pasta@dashboost.org>
Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com>
PastaPastaPasta
force-pushed
the
backport-11687
branch
from
87068fe to
97907b0
Compare
|
Good catch! 3a20581 should fix that. |
|
Cherry-picked |
UdjinM6
added a commit
to UdjinM6/dash
that referenced
this pull request
Jun 29, 2020
UdjinM6
added a commit
that referenced
this pull request
Sep 29, 2020
* Archive v0.15 release notes * Drop changes in release notes accidentally introduced by #3426 * Draft v0.16 release notes * Update doc/release-notes.md Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> * Some additions to 0.16 release notes * Fix typos * Format/TODO * Drop `is` * Block Reward Reallocation, Dynamic Activation Thresholds, PrivateSend coins and fees, PrivateSend Random Round Mixing, GUI, sporks, cmd, commits, contributors * Apply suggestions from code review Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> * Apply few more suggestions * docs: some release note suggestions * Update PRs/commits list Replace "Merged branch .."+commits with the regular "<PR name> (<PR number)" thing * Apply suggestions from code review Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> * Update doc/release-notes.md Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> * Update doc/release-notes.md Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> * Add recent PRs * Apply suggestions from code review Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> * Format/fix trailing whitespaces * Fix duplicate whitespaces * doc: Add details about block reward reallocation * Update doc/release-notes.md Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> * Apply suggestions from code review - wrap file names in `` Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> * doc: Some adjustments in the GUI part Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> Co-authored-by: Alexander Block <ablock84@gmail.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: thephez <thephez@users.noreply.github.com> Co-authored-by: xdustinface <xdustinfacex@gmail.com>
knst
added a commit
to knst/dash
that referenced
this pull request
Oct 28, 2024
knst
added a commit
to knst/dash
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently based on #3412Will be rebased once that is merged.This is a dependency for backporting bitcoin#10740
In the mean time, I need some advise from @UdjinM6 as to how I should fix the autobackup system now that the wallet files are "named" "" if they aren't specified by
-walletI tried moving the InitAutoBackup call in init.cpp down below wallets are opened, and then running backups via CWallet* and not by name. However, when I did this it resulted in no backups being created. (I also tried a bunch of other methods, but each had their own problems associated)
Thanks