Take all nodes into account in check_sigs instead of just just masternodes #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nodes Checking only masternodes might result in wait_for_sigs returning too early when waiting for signatures to get cleaned up, so that node0 still has the signature locally and thus does not fully re-process new signatures.
|
llmq-singing.py (with --spork21) was still failing due to another issue, which is fixed by the newly pushed commit. |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 13, 2022
…nodes (dashpay#3437) * Take all nodes into account in check_sigs instead of just just masternodes Checking only masternodes might result in wait_for_sigs returning too early when waiting for signatures to get cleaned up, so that node0 still has the signature locally and thus does not fully re-process new signatures. * Make sure node0 has received qsendrecsigs from the previously isolated node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking only masternodes might result in wait_for_sigs returning too early
when waiting for signatures to get cleaned up, so that node0 still has
the signature locally and thus does not fully re-process new signatures.
This should fix remaining test failures in llmq-signing.py.