-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge bitcoin#16278: tests: Remove unused includes #4528
Merge bitcoin#16278: tests: Remove unused includes #4528
Conversation
This pull request has conflicts, please rebase. |
c516334
to
e27c1a3
Compare
8e8588a
to
bfe027d
Compare
This pull request has conflicts, please rebase. |
bfe027d
to
b956167
Compare
b956167
to
e293ab7
Compare
e293ab7
to
5dcb498
Compare
ad50aa6
to
7cad30a
Compare
This pull request has conflicts, please rebase. |
7cad30a
to
d35e91c
Compare
d35e91c
to
e0db284
Compare
This pull request has conflicts, please rebase. |
2caa6e0
to
3de39b5
Compare
1aac6bf
to
51ccd6a
Compare
99fe935
to
3f839b0
Compare
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift) Pull request description: Reduce compilation time and unneccessary recompiles by removing unused includes in tests. A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment). ACKs for top commit: Sjors: ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289) Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb
3f839b0
to
89b2ecc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-utACK
(github is doing weird things here again)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK for squash merge
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift) Pull request description: Reduce compilation time and unneccessary recompiles by removing unused includes in tests. A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment). ACKs for top commit: Sjors: ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289) Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb Co-authored-by: MarcoFalke <falke.marco@gmail.com>
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift) Pull request description: Reduce compilation time and unneccessary recompiles by removing unused includes in tests. A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment). ACKs for top commit: Sjors: ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289) Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb Co-authored-by: MarcoFalke <falke.marco@gmail.com>
We don't have below two files to change
wallet/test/ismine_tests.cpp
src/test/key_properties.cpp
removed unused includes from all other files as done by upstream.