Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge bitcoin#16278: tests: Remove unused includes #4528

Merged

Conversation

vijaydasmp
Copy link

@vijaydasmp vijaydasmp commented Oct 21, 2021

We don't have below two files to change
wallet/test/ismine_tests.cpp
src/test/key_properties.cpp
removed unused includes from all other files as done by upstream.

@github-actions
Copy link

This pull request has conflicts, please rebase.

@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch from c516334 to e27c1a3 Compare October 21, 2021 17:00
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch 3 times, most recently from 8e8588a to bfe027d Compare October 23, 2021 01:36
@github-actions
Copy link

This pull request has conflicts, please rebase.

@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch from bfe027d to b956167 Compare October 26, 2021 01:38
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch from b956167 to e293ab7 Compare October 26, 2021 04:04
@vijaydasmp vijaydasmp changed the title Backport v19 vijay batch 2 Backport 19.0 batch 2 Oct 30, 2021
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch from e293ab7 to 5dcb498 Compare November 5, 2021 02:09
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch 3 times, most recently from ad50aa6 to 7cad30a Compare November 13, 2021 15:02
@github-actions
Copy link

This pull request has conflicts, please rebase.

@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch from 7cad30a to d35e91c Compare November 15, 2021 16:23
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch from d35e91c to e0db284 Compare November 15, 2021 18:07
@github-actions
Copy link

This pull request has conflicts, please rebase.

@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch from 2caa6e0 to 3de39b5 Compare November 16, 2021 18:05
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch 3 times, most recently from 1aac6bf to 51ccd6a Compare November 22, 2021 02:20
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch 3 times, most recently from 99fe935 to 3f839b0 Compare November 25, 2021 16:16
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift)

Pull request description:

  Reduce compilation time and unneccessary recompiles by removing unused includes in tests.

  A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment).

ACKs for top commit:
  Sjors:
    ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289)

Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb
@vijaydasmp vijaydasmp force-pushed the backport_v19_vijay_batch_2 branch from 3f839b0 to 89b2ecc Compare November 26, 2021 02:01
@vijaydasmp vijaydasmp marked this pull request as ready for review November 26, 2021 02:02
@vijaydasmp vijaydasmp marked this pull request as draft November 26, 2021 02:05
@vijaydasmp vijaydasmp marked this pull request as ready for review November 26, 2021 02:12
@vijaydasmp
Copy link
Author

@UdjinM6 @PastaPastaPasta

@UdjinM6 UdjinM6 changed the title Backport 19.0 batch 2 Merge bitcoin#16278: tests: Remove unused includes Nov 29, 2021
@UdjinM6 UdjinM6 added this to the 18 milestone Nov 29, 2021
UdjinM6
UdjinM6 previously approved these changes Nov 29, 2021
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK

src/Makefile.am Outdated Show resolved Hide resolved
src/rpc/rawtransaction.cpp Outdated Show resolved Hide resolved
src/rpc/rawtransaction.cpp Outdated Show resolved Hide resolved
src/test/blockencodings_tests.cpp Outdated Show resolved Hide resolved
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
(github is doing weird things here again)

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit b0b8b2d into dashpay:develop Nov 30, 2021
@vijaydasmp vijaydasmp deleted the backport_v19_vijay_batch_2 branch December 29, 2021 01:23
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Nov 10, 2023
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift)

Pull request description:

  Reduce compilation time and unneccessary recompiles by removing unused includes in tests.

  A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment).

ACKs for top commit:
  Sjors:
    ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289)

Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift)

Pull request description:

  Reduce compilation time and unneccessary recompiles by removing unused includes in tests.

  A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment).

ACKs for top commit:
  Sjors:
    ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289)

Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants