Backports 0.19 pr6 #4566
Merged
Backports 0.19 pr6 #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/functional/interface_rpc.py
Outdated
| @@ -4,6 +4,7 @@ | |||
| # file COPYING or http://www.opensource.org/licenses/mit-license.php. | |||
| """Tests some generic aspects of the RPC interface.""" | |||
|
|
|||
| import os | |||
There was a problem hiding this comment.
Suggested change
| import os |
prolly maybe drop this commit
Munkybooty
force-pushed
the
backports-0.19-pr6
branch
from
3c6d562 to
adefb71
Compare
Munkybooty
force-pushed
the
backports-0.19-pr6
branch
from
adefb71 to
18d3f99
Compare
|
This pull request has conflicts, please rebase. |
Munkybooty
force-pushed
the
backports-0.19-pr6
branch
from
18d3f99 to
883a4af
Compare
Munkybooty
force-pushed
the
backports-0.19-pr6
branch
from
883a4af to
042aab0
Compare
Munkybooty
force-pushed
the
backports-0.19-pr6
branch
from
042aab0 to
8297fab
Compare
UdjinM6
requested changes
Nov 20, 2021
…onstructors are marked explicit c4606b8 Add Travis check for single parameter constructors not marked "explicit" (practicalswift) Pull request description: Make single parameter constructors `explicit` (C++11). Rationale from the developer notes: > - By default, declare single-argument constructors `explicit`. > - *Rationale*: This is a precaution to avoid unintended conversions that might > arise when single-argument constructors are used as implicit conversion > functions. ACKs for top commit: laanwj: ACK c4606b8 Tree-SHA512: 3e6fd51935fd93b2604b2188664692973d0897469f814cd745b5147d71b99ea5d73c1081cfde9f6393f51f56969e412fcda35d2d54e938a3235b8d40945f31fd
Munkybooty
force-pushed
the
backports-0.19-pr6
branch
from
8297fab to
c580141
Compare
UdjinM6
requested changes
Nov 29, 2021
Munkybooty
force-pushed
the
backports-0.19-pr6
branch
from
c580141 to
1a360bd
Compare
84edfc7 Update doc and CI config (qmma) 48bcb2a Disable other targets when enable-fuzz is set (qmma) Pull request description: This is to fix bitcoin#16094 When the `enable-fuzz` flag is set, disable all other binary targets. ACKs for top commit: MarcoFalke: ACK 84edfc7 (only checked that travis compiled this) Tree-SHA512: f4ac80526388a67709986b22de88b00bf93ab44ae31a20bd4d8923a4982ab97e015a9f13010081d6ecf6c23ae8afeac7ca9d849d198ce6ebe239aa3127151efc
0512f05 depends: expat 2.2.7 (fanquake) Pull request description: Major changes in expat 2.2.7: * [dashpay#186](libexpat/libexpat#186) [dashpay#262](libexpat/libexpat#262) Fix extraction of namespace prefixes from XML names; XML names with multiple colons could end up in the wrong namespace, and take a high amount of RAM and CPU resources while processing, opening the door to use for denial-of-service attacks * [dashpay#227](libexpat/libexpat#227) Autotools: Add --without-examples and --without-tests Full changelog is available [here](https://github.com/libexpat/libexpat/blob/R_2_2_7/expat/Changes#L5). ACKs for top commit: laanwj: ACK 0512f05 Tree-SHA512: 45162a9b0011107fd59a97dae7b5eb61989dafbec26b1ee497d1b11bf5c6a119971096899caa2998648b82a62db57c629a1560453557146c2496b39a7f3f8de9
96b6dd4 Remove redundant pre-TopUpKeypool checks (Gregory Sanders) Pull request description: TopUpKeypool already has a quick check for `IsLocked()` ACKs for top commit: achow101: ACK 96b6dd4 Reviewed the diff and checked that the `if (!IsLocked()) TopUpKeypool()` pattern is changed everywhere. Tree-SHA512: 36f5ae1be611404656ac855763e569fd3b5e932db8170f39ebda74300aa02062774b2c28ce6cf00f2ccc0e3550de58df36efa9097e24f0a51f2809b8a489c95a
fa0d0ff Remove unused bits from the service flags enum (MarcoFalke) Pull request description: Remove all bits that have no BIP specification nor can be observed on the active network ACKs for top commit: practicalswift: utACK fa0d0ff LarryRuane: utACK fa0d0ff promag: ACK fa0d0ff. laanwj: ACK fa0d0ff Tree-SHA512: 6342017bfd4c2a39c998fbb02497931b11892e1cb60fc13b948b91812f281b605a25a3fdc0d5358dff18da4e82eb4eb4de95c43c7e76ecb331c1c3985443dd21
…test ae311bc Fix autostart filenames on Linux (Hennadii Stepanov) Pull request description: Currently, on master the `bitcoin-test.lnk` and `bitcoin-regtest.lnk` files do not work as autostart application `.desktop` files. This PR fixes it. Refs: - bitcoin#7045 - [Autostart Of Applications During Startup](https://standards.freedesktop.org/autostart-spec/autostart-spec-latest.html) ACKs for top commit: promag: utACK ae311bc, weird why extension `.lnk` was used in bitcoin#7045. laanwj: Code review ACK ae311bc Tree-SHA512: 210cc346600d52b0a262c81ed5f258365a3cea2e5522f4b5f4798fd3b54f45ed82aba68eefae59a6b6f1d8e4d00221476c23bdffc038f16f2f45c1acc837f522
Munkybooty
force-pushed
the
backports-0.19-pr6
branch
from
1a360bd to
9cefc2f
Compare
PastaPastaPasta
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr also adds a functional test mempool_package_onemore.py and i haven't been able to get it to pass.