V0.12.0.x more locks fixes #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use FindNode instead of explicit loops - Do not use FindNode where we can grab node right from ConnectNode (slightly less cs_vNodes)
- do not lock cs_main for mnodeman.CheckAndRemove() - we have trylock inside CMasternode.Check, should be enough - fast cs_main lock for ix - use RelayInv instead of manually locking nodes / pushing inv - do not lock cs_vNodes / ClearFulfilledRequest on every 100th block, CMasternodeSync should already handle resync by itself better now
eduffield222
pushed a commit
that referenced
this pull request
Aug 5, 2015
V0.12.0.x more locks fixes
PastaPastaPasta
added a commit
that referenced
this pull request
Oct 26, 2024
…403, #418, #416, #449, #477, #563, #554, #615 (qt backports: part 2) 1a2c02a merge bitcoin-core/gui#615: If -prune=0 is set, Uncheck Prune on Intro page (Kittywhiskers Van Gogh) 3d5aca6 merge bitcoin-core/gui#554: Add and improve translator comments and tooltips for peers tab address fields (Kittywhiskers Van Gogh) 0c545ac merge bitcoin-core/gui#563: Remove network detection based on address in BIP21 (Kittywhiskers Van Gogh) f088334 merge bitcoin-core/gui#477: Monospaced output in Console on macOS (Kittywhiskers Van Gogh) 694f3e9 merge bitcoin-core/gui#449: Restore "S" accelerator for "Start on system login" option (Kittywhiskers Van Gogh) 063ef3a merge bitcoin-core/gui#416: Add RPC setting (Kittywhiskers Van Gogh) fa2f7ac merge bitcoin-core/gui#418: fix bitcoin-qt app categorization on apple silicon (Kittywhiskers Van Gogh) 594177d merge bitcoin-core/gui#403: Make paths to update Encryption and HD wallet statuses simpler (Kittywhiskers Van Gogh) ba5ad1f merge bitcoin-core/gui#349: replace QDateTime::fromTime_t with QDateTime::fromSecsSinceEpoch (Kittywhiskers Van Gogh) 70d4e08 merge bitcoin-core/gui#317: Add Direction column to Peers Tab (Kittywhiskers Van Gogh) 0a5481c merge bitcoin-core/gui#354: Refactor open date range to use std::optional (Kittywhiskers Van Gogh) 17a7e9b merge bitcoin-core/gui#337: Use Regex Search in Apptests (Kittywhiskers Van Gogh) Pull request description: ## Additional Information | `develop` (3a18f08) | This PR | | ------------------------------------------------------------ | ------------------------------------------------------------ | |  |  | |  |  | ## Breaking changes None observed. ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas (note: N/A) - [x] I have added or updated relevant unit/integration/functional/e2e tests (note: N/A) - [x] I have made corresponding changes to the documentation (note: N/A) - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 1a2c02a Tree-SHA512: d424a0ebe817c08a50c2455fea1c3bf798a1a53dd87bc9b71cd7173824d7892a83035f046dfccc85d1925b91705d4db7ac2a498e4299d91504a1a8306762e5b0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectNode/FindNide:
FindNode()instead of explicit loopsFindNode()where we can grab node right fromConnectNode()(slightly lesscs_vNodes)Few more lock-related fixes:
cs_mainformnodeman.CheckAndRemove()- we haveTRY_LOCKinsideCMasternode.Check(), should be enough imocs_mainlock for ixRelayInv()instead of manually locking nodes / pushing invClearFulfilledRequest()(and do not lockcs_vNodes) on every 100th block,CMasternodeSyncshould already handle resync by itself better nowWorks for me but it would be nice to have throughout review/testing 😉