V0.12.0.x support old masternodes (dsee/dseep) #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- inject our node in old masrternodes' list / ping accordingly - ignore dsee/dseep after SPORK_10_MASTERNODE_PAY_UPDATED_NODES is activated
|
Added more dsee/dseep support to v12 nodes, they should appear on v11 network now https://dashtalk.org/threads/v12-testing-thread.5484/page-130#post-62512 |
eduffield222
pushed a commit
that referenced
this pull request
Aug 9, 2015
V0.12.0.x support old masternodes (dsee/dseep)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
SPORK_10_MASTERNODE_PAY_UPDATED_NODESwill not work because we have no message handlers for old masternodes (dsee/dseep messages) and they will never get into the list. Here is a "Light" version for OLD MASSTERNODES ported from v11 - fake pings, no self-activation. We can remove this after migration to v12 is done.