Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default quorums for devnet #5635

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

knst
Copy link
Collaborator

@knst knst commented Oct 20, 2023

Issue being fixed or feature implemented

To make configuring devnets more error-prune and config file shorter

What was done?

Updated default LLMQ parameters on devnet from 50_60, 60_75, 100_67 to LLMQ_DEVNET and LLMQ_DEVNET_PLATFORM.

How Has This Been Tested?

not tested yet; would be tested on devnets later with next devnet/release

Breaking Changes

n/a for non-dev-nets; for dev-net other default quorum is used.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 20 milestone Oct 20, 2023
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also update defaults for corresponding cmd line args in chainparamsbase.cpp

src/chainparams.cpp Outdated Show resolved Hide resolved
knst and others added 3 commits October 20, 2023 23:56
To make configuring devnets more error-prune and config file shorter
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
@knst knst force-pushed the fix-devnet-defaults branch from 3251e2d to 79490b5 Compare October 20, 2023 16:59
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit 9cfc3a6 into dashpay:develop Oct 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants