Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: Merge bitcoin#22860 #6134

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

vijaydasmp
Copy link

bitcoin backports

@vijaydasmp vijaydasmp changed the title Merge bitcoin/bitcoin#22100: refactor: Clean up new wallet spend, rec… Merge bitcoin/bitcoin#22100 Jul 21, 2024
@vijaydasmp vijaydasmp changed the title Merge bitcoin/bitcoin#22100 backport: Merge bitcoin/bitcoin#22100 Jul 21, 2024
@vijaydasmp vijaydasmp force-pushed the bp23_96 branch 3 times, most recently from 657a34d to 236d42c Compare July 21, 2024 10:53
@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin/bitcoin#22100 backport: Merge bitcoin/bitcoin#22860, 22907 Jul 21, 2024
@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin/bitcoin#22860, 22907 backport: Merge bitcoin#22860, 22907 Jul 21, 2024
@vijaydasmp vijaydasmp force-pushed the bp23_96 branch 4 times, most recently from 890dbc2 to e352a43 Compare July 26, 2024 17:48
@vijaydasmp
Copy link
Author

Hello @UdjinM6 , requesting for review

@vijaydasmp vijaydasmp marked this pull request as ready for review July 28, 2024 04:39
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e352a43

@vijaydasmp
Copy link
Author

Hello @PastaPastaPasta , requesting review

@vijaydasmp
Copy link
Author

vijaydasmp commented Aug 8, 2024

Hello @knst , requesting review

@vijaydasmp
Copy link
Author

Hello @PastaPastaPasta , requesting review

@UdjinM6
Copy link

UdjinM6 commented Aug 14, 2024

Needs rebase to fix Check Merge Fast-Forward Only

@vijaydasmp vijaydasmp force-pushed the bp23_96 branch 2 times, most recently from 09a36cd to 45d4899 Compare August 18, 2024 12:16
@vijaydasmp vijaydasmp changed the title backport: Merge bitcoin#22860, 22907 backport: Merge bitcoin#22860 Aug 18, 2024
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 1601a21

…x test

fa1b08e test: Always clear reject reason in IsStandard tx test (MarcoFalke)

Pull request description:

  For some tests the reject reason wasn't cleared between runs and thus subsequent tests might (theoretically) fail to verify the correct reject reason.

ACKs for top commit:
  benthecarman:
    ACK fa1b08e
  theStack:
    Code-review ACK fa1b08e

Tree-SHA512: fcb727a690f92a4cf06127c302ba464f1e8cb997498e4f7fd9e210d193559b07e6efdb9d5c8a0bef3fe643bdfd5fedd431aaace20978dd49e56b8e770cb9f930
@PastaPastaPasta PastaPastaPasta merged commit 045e178 into dashpay:develop Aug 22, 2024
10 checks passed
@UdjinM6 UdjinM6 added this to the 21.2 milestone Aug 23, 2024
@UdjinM6 UdjinM6 modified the milestones: 21.2, 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants