fix: avoid voting for the same trigger multiple times #6155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
force-pushed
the
fix_multivote
branch
3 times, most recently
from
fc7425b to
761f5c0
Compare
UdjinM6
commented
Aug 5, 2024
why not increase this timeout? |
src/governance/governance.cpp
Outdated
Comment on lines
741
to
766
| ranges::any_of(voteRecord.mapInstances, [&](const auto& voteInstancePair) { | ||
| if (voteInstancePair.first == VOTE_SIGNAL_FUNDING) { | ||
| if (voteInstancePair.second.eOutcome == VOTE_OUTCOME_YES) { | ||
| votedFundingYesTriggerHash = gov_sb_hash; | ||
| } | ||
| LogPrint(BCLog::GOBJECT, /* Continued */ | ||
| "CGovernanceManager::%s " | ||
| "Not voting YES-FUNDING for trigger:%s, we voted %s for it already\n", | ||
| strFunc, gov_sb_hash.ToString(), | ||
| CGovernanceVoting::ConvertOutcomeToString(voteInstancePair.second.eOutcome)); | ||
| return true; | ||
| } | ||
| return false; | ||
| }); |
There was a problem hiding this comment.
I'm confused.. you're doing ranges::any_of, but discarding the return values?
UdjinM6
force-pushed
the
fix_multivote
branch
3 times, most recently
from
11b6dba to
4d61b7b
Compare
src/governance/governance.cpp
Outdated
| if (vote_rec_t voteRecord; trigger_opt.value().GetCurrentMNVotes(mn_activeman.GetOutPoint(), voteRecord)) { | ||
| const auto& strFunc = __func__; | ||
| // Let's see if there is a VOTE_SIGNAL_FUNDING vote from us already | ||
| ranges::any_of(voteRecord.mapInstances, [&](const auto& voteInstancePair) { |
There was a problem hiding this comment.
still discarding this return value
PastaPastaPasta
previously approved these changes
Aug 22, 2024
There was a problem hiding this comment.
utACK 3e78081; I do wish there was a regression test maybe, but otherwise looks good
|
ping @knst |
knst
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We just had a sb voting period and I noticed that the network is way too spammy and produces too many votes (10x+ the expected numbers). It turns out that relying on
ProcessVoteAndRelayon mainnet is not enough because rate-check expires too soon and MNs are able to vote again and again. On testnet it was never an issue because the voting period there is really short.What was done?
Check known votes to make sure we never voted earlier.
How Has This Been Tested?
Run tests, run a MN on mainnet and check logs.
Breaking Changes
n/a
Checklist: