Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamically register MN in functional tests without IS #6430

Conversation

knst
Copy link
Collaborator

@knst knst commented Nov 26, 2024

This PR has important fixes to implement "single-node quorum" feature.

Issue being fixed or feature implemented

Without IS-quorum you can not dynamically add a new MN or Evo node.
For evo nodes adding it dynamically is the only way.

What was done?

Fixed a function that dynamically adds a masternode without Instant Send quorums; use it in a functional test feature_asset_locks.py

As side effect it improves performance of functional tests which do not wait more IS lock significantly; for feature_asset_locks.py it gave ~20 seconds per run.

How Has This Been Tested?

See updates in feature_asset_locks.py, feature_llmq_evo.py, feature_dip3_v19.py

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@knst knst added this to the 22.1 milestone Nov 26, 2024
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 37fbdee

@knst knst mentioned this pull request Nov 28, 2024
5 tasks
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 37fbdee

Although I would say I'd prefer this to be scope "test" or something similar, as it's hard to call these changes a feat

@PastaPastaPasta PastaPastaPasta merged commit f6edb8a into dashpay:develop Dec 2, 2024
22 checks passed
@knst knst deleted the feat-improve-dynamically_prepare_masternode branch December 2, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants