Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for listunspent with coinType option #6445

Merged
merged 1 commit into from
Dec 11, 2024
Merged

test: add tests for listunspent with coinType option #6445

merged 1 commit into from
Dec 11, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 3, 2024

Issue being fixed or feature implemented

extend tests a bit

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 22.1 milestone Dec 3, 2024
PastaPastaPasta
PastaPastaPasta approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f3be9bc

@UdjinM6 UdjinM6 requested a review from knst December 7, 2024 14:09
@UdjinM6
Copy link
Author

UdjinM6 commented Dec 11, 2024

ping @knst

knst
knst approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM f3be9bc

@PastaPastaPasta PastaPastaPasta merged commit c07073d into dashpay:develop Dec 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@knst knst knst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.1
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @knst @PastaPastaPasta