backport: merge bitcoin#27452, #29347, #29356, #29353, #29452, #29483, #30545, #31383 (BIP324 backports: part 5)

[kwvg]

Additional Information

• When backporting bitcoin#27452 in feature_anchors.py, P2P_SERVICES (NODE_NETWORK | NODE_HEADERS_COMPRESSED) has been replaced with NODE_NETWORK as the former evaluates to a value greater than 256 (specifically 2049), which causes test failure. The replacement value is acceptable as NODE_NETWORK is the desired service flag expected by Dash Core (source).

  Test failure:

  dash@89afd55ae77e:/src/dash$ ./test/functional/feature_anchors.py
  2024-12-14T12:31:22.244000Z TestFramework (INFO): PRNG seed is: 8365703189892653614
  2024-12-14T12:31:22.244000Z TestFramework (INFO): Initializing test directory /tmp/dash_func_test_j0ya02yu
  2024-12-14T12:31:22.776000Z TestFramework (INFO): When node starts, check if anchors.dat doesn't exist
  2024-12-14T12:31:22.776000Z TestFramework (INFO): Add 2 block-relay-only connections to node
  2024-12-14T12:31:24.781000Z TestFramework (INFO): Add 5 inbound connections to node
  2024-12-14T12:31:29.843000Z TestFramework (INFO): Check node connections
  2024-12-14T12:31:30.848000Z TestFramework (INFO): Check the addresses in anchors.dat
  2024-12-14T12:31:30.848000Z TestFramework (INFO): Perturb anchors.dat to test it doesn't throw an error during initialization
  2024-12-14T12:31:31.356000Z TestFramework (INFO): When node starts, check if anchors.dat doesn't exist anymore
  2024-12-14T12:31:31.357000Z TestFramework (INFO): Ensure addrv2 support
  2024-12-14T12:31:32.364000Z TestFramework (INFO): Add 256-bit-address block-relay-only connections to node
  2024-12-14T12:31:33.368000Z TestFramework (INFO): Check for addrv2 addresses in anchors.dat
  2024-12-14T12:31:33.369000Z TestFramework (ERROR): Unexpected exception caught during testing
  Traceback (most recent call last):
    File "/src/dash/test/functional/test_framework/test_framework.py", line 161, in main
      self.run_test()
    File "/src/dash/./test/functional/feature_anchors.py", line 135, in run_test
      new_data[services_index] = P2P_SERVICES
  ValueError: byte must be in range(0, 256)
  2024-12-14T12:31:33.870000Z TestFramework (INFO): Stopping nodes
  2024-12-14T12:31:33.871000Z TestFramework (WARNING): Not cleaning up dir /tmp/dash_func_test_j0ya02yu
  2024-12-14T12:31:33.871000Z TestFramework (ERROR): Test failed. Test logging available at /tmp/dash_func_test_j0ya02yu/test_framework.log
  

Breaking Changes

None expected.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas (note: N/A)
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[UdjinM6]

utACK c6f23a7

[UdjinM6]

29356: nit: probably partial because of missing bool use_v2transport = self.Arg<bool>(2); part, not sure

[kwvg]

self.Arg<bool>(2) is the equivalent of request.params[2].get_bool(), the newer syntax being introduced in bitcoin#28230 and fleshed out in bitcoin#29277, backporting them out of order brings little benefit but would make backports until that point annoying at best, so it was decided to skip that change but not mark it as partial as the behaviour should be identical.

Though the !request.params[2].isNull() half of use_v2transport is a no-op as v2transport is no longer optional and is a nit that can be addressed later on.

[PastaPastaPasta]

utACK c6f23a7;

looks good enough to me :) a few nits you can consider and if you want, can apply in another PR.