Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add functional tests for coinjoinsalt RPC #6492

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Dec 15, 2024

Additional Information

  • Current suite of tests do not check if restoring salt results in restoring CoinJoin balance. This is because functional tests currently do not test CoinJoin mixing (and thus, routines for the same are not currently present).

Breaking Changes

None expected.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 22.1 milestone Dec 15, 2024
@kwvg kwvg requested a review from knst December 15, 2024 16:59
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall 3106add

just a note:
if #6479 will get merged first, need to update this PR to remove coinjoinsalt from list of exception; if this PR get merged first I need to update 6479

UPD: 6479 got merged, please remove an exception for coinjoinsalt

test/functional/rpc_coinjoinsalt.py Outdated Show resolved Hide resolved
test/functional/test_runner.py Outdated Show resolved Hide resolved
@kwvg kwvg requested a review from knst December 16, 2024 10:47
@knst knst marked this pull request as ready for review December 16, 2024 11:51
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 16c2e13

@kwvg kwvg changed the title test: add functional test for coinjoinsalt RPC test: add functional tests for coinjoinsalt RPC Dec 16, 2024
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 16c2e13

@PastaPastaPasta PastaPastaPasta merged commit 0968a00 into dashpay:develop Dec 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants