Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating some URLs #753

Closed
wants to merge 1 commit into from
Closed

updating some URLs #753

wants to merge 1 commit into from

Conversation

taw00
Copy link

@taw00 taw00 commented Apr 4, 2016

No description provided.

@@ -18,7 +18,7 @@ are carried out collectively by the network. Dash Core is the name of open
source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of
the Dash Core software, see https://www.dashpay.io/downloads.
the Dash Core software, see https://www.dash.org/downloads.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch is incomplete - it doesn't fix line number 4.
And it's already fixed in 12.1 btw.

@UdjinM6
Copy link

UdjinM6 commented Apr 4, 2016

Thanks for contributing!

However there are some issues with these changes, see line comments above.

Another thing to note: we don't merge PRs into master branch, we use dev branches for this. Please submit to v0.12.0.x (stable/current version) and v0.12.1.x (test/dev version) branches only.

@taw00
Copy link
Author

taw00 commented Apr 4, 2016

Hey. Okay. (a) Can't believe my eyes just swooped right over the other URL. And (b) ... I haven't looked at the dev branches yet, but maybe the README.md really needs to be updated to mention that. Of course, there are a number of TODOs in there... as there always are.

Thanks for kindly redirecting me. I will fork from a different branch. :)

@taw00 taw00 closed this Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants