Enable PPA builds #896
Enable PPA builds #896
Conversation
- this merges the latest Bitcoin changes and should enable us to provide Dash PPAs via https://launchpad.net/~dash.org/+archive/ubuntu/dash Closes #880
| @@ -15,7 +15,7 @@ To install: | |||
|
|
|||
| If you build yourself, you will either need to modify the paths in | |||
| the .desktop file or copy or symlink your dash-qt binary to `/usr/bin` | |||
| and the `../../share/pixmaps/dash128.png` to `/usr/share/pixmaps` | |||
| and the `../../share/pixmaps/bitcoin128.png` to `/usr/share/pixmaps` | |||
There was a problem hiding this comment.
Actually, if we want to avoid conflicts with bitcoin packages imo it's time to fix bitcoin->dash for pixmaps https://github.com/dashpay/dash/tree/master/share/pixmaps (and references to them)
There was a problem hiding this comment.
This is out of scope of this PR - i just wanted it to be accurate (and reflect the current state) :)
There was a problem hiding this comment.
Errr... I'm not sure if it makes sense to enable ppa builds which will conflict with some existing one... how about fixing /contrib/debian/dash-qt.install instead (at least that's the only reference I found) and renaming bitcoin128.png to dash128.png?
There was a problem hiding this comment.
actually there are 2 more files referenced in /contrib/debian/dash-qt.install - bitcoin32.xpm and bitcoin16.xpm and I can't find any more references to them so renaming all 3 of them shouldn't break anything else imo
There was a problem hiding this comment.
Okok :) So we'll rename all bitcoin*.* files in share/pixmap and their references?
edit: n/m, saw your post re. 3 references to late :)
There was a problem hiding this comment.
yep, will require to fix winfows packaging too though because of bitcoin.ico (Makefile.am and setup.nsi.in)... or let's start with bitcoin*.png and bitcoin*.xpm for debian packaging only changes :)
|
Btw, this is just for documentation purposes, Bitcoin is not even maintaining their contrib/debian folder anymore, maybe i should open a PR at Bitcoin as well :) |
|
Pushed 7ad1ea8 |
|
Pushed 05e0a12 |
|
Pushed da7ef9c - rename the missing |
| technology to operate with no central authority: managing transactions | ||
| and issuing money are carried out collectively by the network. Dash Core | ||
| is the name of the open source software which enables the use of this currency. | ||
| Dash is a free open source peer-to-peer electronic cash system that |
There was a problem hiding this comment.
I probably commented on a wrong line previously, so rephrasing here...
This description was matching readme and a newly proposed version doesn't. I like "readme" version more then a newly proposed one, imo current one is more accurate, no need to change it. Also I'm not sure where is new one came from - both 12.0 and 12.1 have same ("readme") version, not the new one.
There was a problem hiding this comment.
I have no idea either. The one committed now is from Bitcoin 12.1 with Bitcoin replaced by Dash :)
… the main README.md file
|
Pushed d0d2f05 |
… the main README.md file
|
Pushed 3dc2bab |
|
utACK 3dc2bab Hope it actually works ;) |
Closes #880