Refactor All The Things - part1 #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,3 @@ | |||
|
|
|||
| // Copyright (c) 2009-2012 The Dash Core developers | |||
There was a problem hiding this comment.
nit: Copyright (c) 2014-2016 The Dash Core developers
|
utACK 9bc414c - love it ❤️ Shall we squash for merge or keep it as is? |
|
@schinzelh nit addressed. I'm fine with either way, I separated them only to make review easier :) |
|
Ooops, forgot to include |
|
LOVE it ❤️ Much easier to read and understand now. 100% utACK |
|
After merging #911 this needs a rebase now :) |
+ move strMasterNodeAddr to CActiveMasternode
+ new lock cs_instantsend to protect maps on CleanTransactionLocksList() + new DEFAULT_INSTANTSEND_DEPTH constant + rename MIN_INSTANTX_PROTO_VERSION to MIN_INSTANTSEND_PROTO_VERSION and bump it
+ decouple from util.h and version.h + more functions for CDarksendBroadcastTx: constructors, signing, serialization + move from rand() to insecure_rand() in general but to GetRand() for session id + fix defaults
|
utACK d24182c |
|
lol, holy crap udjin 👍 I need a bit of time to review this, but I'll get to it soon :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright... Time to clean up my diff backlog :)
I apologize in advance for a somewhat huge PR but things are way too interconnected here and also changes are mostly trivial. I tried to break it into 3 more or less separated commits though, so hopefully this will help to make review a bit easier. Also would like to mention that this is the first part of it and there is more to come in following PRs but I need this as a base (together with #911), so please don't put it at the end of your review queue :D
In general all of this is simply trying to:
CActiveMasternodestrMasterNodeAddrout of util.h toCActiveMasternodecs_instantsendto protect maps onCleanTransactionLocksList()DEFAULT_INSTANTSEND_DEPTHconstantMIN_INSTANTX_PROTO_VERSIONtoMIN_INSTANTSEND_PROTO_VERSIONand bump itfEnableInstantSendandnInstantSendDepthout of util.hCConsensusVote::GetHash()currently works i.e. it doesn't return a hash at all.CDarksendBroadcastTx: constructors, signing, serializationinsecure_rand()instead of rand() in general butGetRand()for session idDEFAULT_...nPrivateSendRounds,nPrivateSendAmount,nLiquidityProvider,fEnablePrivateSend,fPrivateSendMultiSession,darkSendDenominationsout of util.hNote:
vinpart of some names was changed totxin(which is a proper name for an object ofCTxInbecausevinstands for vector ofCTxIns) where applicable but not everywhere. That's intentional, I'll explain this in (one of?) the next part :)