[UI] IPv4, IPv6 and TOR stats added to Information tab #930
Conversation
crowning-
changed the title
|
Like the idea but the implementation can be improved imo - all "id"s and functions are already in place, see: |
| { | ||
| case NODE_IPV4: | ||
| return nIPv4_nodes; | ||
| break; |
|
Thanks a lot, I didn't know the constants are all there already. Having ALWAYS a break statement is IMO good practice, someone might change the code and forget to put them back in. No problem to delete them here as it's just one line of code anyway, though. I'll check whether the compiler gives a warning when I move the last return statement. If not, I'll make it the default of the switch |
|
Done. |
|
utACK aaa320e Yep, will squash on merge :) |
|
Nice, utACK aaa320e :) |
I think it's convenient to have this information inside the wallet instead from some suspicious external websites :-)
Looks like this:
