-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging back changes from bitcore-node #5
Comments
(We are now adding dash support to mytrezor) |
I'l have a look at it. |
@snogcel I have rebased bitcore-node-dash to bitcore-node-3.1.3. Travis looks good, please release bitcore-node-dash-3.1.3 to npmjs |
tnx flare, I've published bitcore-node-dash@3.1.3 to npmjs. @Runn1ng can you please confirm? |
Hello, sorry for ignoring this :( master_3.1.3 really has the necessary fixes. However, the master_3.1.3 and master started to diverge when I look at it :/ can you please merge. Thanks a lot Also - note that bitpay started ignoring bitcore development. Since we really needed fixes for segwit (probably not applicable on dash), we started having our own forks https://github.com/satoshilabs?utf8=%E2%9C%93&q=insight&type=&language= Right now I can't promise we will keep them maintained; for that reason we didn't add them to npm (so it doesn't seem like we are "promising" to maintain) and we are installing everything from github commits; we might change that in the future. |
This issue was moved to #31 |
This issue is a bit ancient at this time, and the repo at https://github.com/dashevo/dashcore-node should have the newest changes and be up-to-date with the original BitPay upstream. We're in the process of merging this repo w/the dashevo one, so should be ok to close this. |
just fyi, since this resurfaced in my mentions we are in a process of migrating away from bitcore+insight since it is hard to maintain for multiple currencies and we are building an open source coin agnostic indexer + API. So far it does not include frontend explorer |
Can you please merge changes back from bitcore-node 3.1.3 (and publish the result to npm)?
I am developing MyTrezor, there is a bug fixed in bitcore-node 3.1.3 with mempool, that would help us if it was fixed.
The text was updated successfully, but these errors were encountered: