Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging back changes from bitcore-node #5

Closed
karelbilek opened this issue Nov 3, 2016 · 8 comments
Closed

Merging back changes from bitcore-node #5

karelbilek opened this issue Nov 3, 2016 · 8 comments

Comments

@karelbilek
Copy link

Can you please merge changes back from bitcore-node 3.1.3 (and publish the result to npm)?

I am developing MyTrezor, there is a bug fixed in bitcore-node 3.1.3 with mempool, that would help us if it was fixed.

@karelbilek
Copy link
Author

(We are now adding dash support to mytrezor)

@schinzelh
Copy link

I'l have a look at it.

@schinzelh
Copy link

@snogcel I have rebased bitcore-node-dash to bitcore-node-3.1.3. Travis looks good, please release bitcore-node-dash-3.1.3 to npmjs

@snogcel
Copy link

snogcel commented Nov 3, 2016

tnx flare, I've published bitcore-node-dash@3.1.3 to npmjs.

@Runn1ng can you please confirm?

@karelbilek
Copy link
Author

karelbilek commented May 3, 2017

Hello, sorry for ignoring this :(

master_3.1.3 really has the necessary fixes. However, the master_3.1.3 and master started to diverge when I look at it :/ can you please merge. Thanks a lot

Also - note that bitpay started ignoring bitcore development. Since we really needed fixes for segwit (probably not applicable on dash), we started having our own forks

https://github.com/satoshilabs?utf8=%E2%9C%93&q=insight&type=&language=
https://github.com/satoshilabs?utf8=%E2%9C%93&q=bitcore&type=&language=
https://github.com/satoshilabs/bitcoin (<-this is bitcore patchset rebased on latest bitcoin-core)

Right now I can't promise we will keep them maintained; for that reason we didn't add them to npm (so it doesn't seem like we are "promising" to maintain) and we are installing everything from github commits; we might change that in the future.

@KamuelaFranco
Copy link

This issue was moved to #31

@nmarley
Copy link

nmarley commented May 12, 2018

This issue is a bit ancient at this time, and the repo at https://github.com/dashevo/dashcore-node should have the newest changes and be up-to-date with the original BitPay upstream.

We're in the process of merging this repo w/the dashevo one, so should be ok to close this.

@nmarley nmarley closed this as completed May 12, 2018
@karelbilek
Copy link
Author

just fyi, since this resurfaced in my mentions

we are in a process of migrating away from bitcore+insight since it is hard to maintain for multiple currencies and we are building an open source coin agnostic indexer + API. So far it does not include frontend explorer

https://github.com/jpochyla/blockbook

nmarley pushed a commit that referenced this issue May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants