Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support deadlock detection on android #250

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Apr 5, 2024

Issue being fixed or feature implemented

Allow deadlock detection to be supported on Android.

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@HashEngineering HashEngineering self-assigned this Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 48.00%. Comparing base (f62029d) to head (b386f45).

Files Patch % Lines
...re/src/main/java/org/bitcoinj/utils/Threading.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     48.00%   48.00%   -0.01%     
+ Complexity     6669     6667       -2     
============================================
  Files           409      409              
  Lines         46133    46137       +4     
  Branches       6502     6502              
============================================
  Hits          22148    22148              
- Misses        21575    21578       +3     
- Partials       2410     2411       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HashEngineering HashEngineering merged commit d161488 into master Apr 8, 2024
4 of 7 checks passed
@HashEngineering HashEngineering deleted the feat-support-deadlock-detection-android branch June 25, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants