fix: add tls-webpki-roots to support tls on mobile (Android, iOS) #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
requested review from
shumkov and
QuantumExplorer
as code owners
3 tasks
lklimek
approved these changes
Apr 22, 2024
QuantumExplorer
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
It was found that on Android, there were TLS connection errors. After investigating this issue was found with
tonichyperium/tonic#1403.
What was done?
The solution is to add the feature
tonic/tls-webpki-rootsto thedapi-grpccrate.How Has This Been Tested?
This change was verified on Android and Mac, though in both cases using C Bindings generated by Ferment and run using Java.
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only