Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rs-drive-abci)!: commit and vote extensions signature verification #915

Merged
merged 20 commits into from
Apr 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3ef2782
fix(rs-drive-abci): withdrawal: don't compare empty signature
lklimek Apr 13, 2023
cbe70fc
feat(rs-drive-abci): validate commit signature
lklimek Apr 14, 2023
2da23cf
chore(rs-drive-abci): get rid of some warnings
lklimek Apr 14, 2023
9b87be5
feat(rs-drive-abci): commit validation - WIP
lklimek Apr 17, 2023
e194707
Merge remote-tracking branch 'origin/feat/abci_validation' into feat/…
lklimek Apr 17, 2023
ec645e4
test(rs-drive-abci): cleanup tests
lklimek Apr 17, 2023
85e537e
Merge remote-tracking branch 'origin/feat/abci_validation' into feat/…
lklimek Apr 17, 2023
4542c0f
chore(rs-drive-abci): fix after merge
lklimek Apr 17, 2023
d0c02b9
chore(rs-drive-abci): self-review
lklimek Apr 17, 2023
ee3c843
Merge remote-tracking branch 'origin/feat/abci_validation' into feat/…
lklimek Apr 17, 2023
d57736c
test(rs-drive-abci): fix commit tests
lklimek Apr 17, 2023
c85074a
feat(rs-drive-abci): withdrawal tx signature verification
lklimek Apr 17, 2023
af06de3
Merge remote-tracking branch 'origin/feat/abci_validation' into feat/…
lklimek Apr 17, 2023
8d8dfcf
chore(rs-drive-abci): fix some imports
lklimek Apr 17, 2023
1cbc1dc
test(rs-drive-abci): withdrawals/vote extensions tests
lklimek Apr 17, 2023
4e37450
fix(rs-drive-abci): config quorum type doesn't work
lklimek Apr 17, 2023
ff502f2
fix(rs-drive-abci): missing BLOCK_SPACING_MS in .env.example
lklimek Apr 17, 2023
d9ea054
refactor(rs-drive-abci): withdrawal verify signature returns SimpleVa…
lklimek Apr 18, 2023
cd49ff3
Merge remote-tracking branch 'origin/feat/abci_validation' into feat/…
lklimek Apr 18, 2023
9cdb803
test(rs-drive-abci): fix withdrawal tests
lklimek Apr 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 12 additions & 56 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ members = [
"packages/masternode-reward-shares-contract",
"packages/feature-flags-contract",
"packages/dpns-contract",
"packages/data-contracts"
"packages/data-contracts",
]
61 changes: 36 additions & 25 deletions packages/rs-dpp/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,46 +5,57 @@ edition = "2018"
authors = ["Anton Suprunchuk <anton.suprunchuk@gmail.com>"]

[dependencies]
anyhow = { version = "1.0.70"}
async-trait = { version = "0.1"}
anyhow = { version = "1.0.70" }
async-trait = { version = "0.1" }
base64 = "0.20.0"
bls-signatures = { git = "https://github.com/dashpay/bls-signatures", branch = "feat/threshold_bindings" }
bs58 = "0.4.0"
byteorder = { version="1.4"}
chrono = { version="0.4.20", default-features=false, features=["wasmbind", "clock"]}
ciborium = { git="https://github.com/qrayven/ciborium", branch="feat-ser-null-as-undefined"}
dashcore = { git="https://github.com/dashpay/rust-dashcore", features=["std", "secp-recovery", "rand", "signer", "use-serde"], default-features = false, branch = "feat/addons" }
env_logger = { version="0.9"}
futures = { version ="0.3"}
getrandom= { version="0.2", features=["js"]}
hex = { version = "0.4"}
integer-encoding = { version="3.0.4"}
itertools = { version ="0.10"}
byteorder = { version = "1.4" }
chrono = { version = "0.4.20", default-features = false, features = [
"wasmbind",
"clock",
] }
ciborium = { git = "https://github.com/qrayven/ciborium", branch = "feat-ser-null-as-undefined" }
dashcore = { git = "https://github.com/dashpay/rust-dashcore", features = [
"std",
"secp-recovery",
"rand",
"signer",
"use-serde",
], default-features = false, branch = "feat/addons" }
env_logger = { version = "0.9" }
futures = { version = "0.3" }
getrandom = { version = "0.2", features = ["js"] }
hex = { version = "0.4" }
integer-encoding = { version = "3.0.4" }
itertools = { version = "0.10" }
json-patch = "0.2.6"
jsonptr = "0.1.5"
jsonschema = { git="https://github.com/fominok/jsonschema-rs", branch="feat-unevaluated-properties", default-features=false, features=["draft202012"] }
lazy_static = { version ="1.4"}
log = { version="0.4"}
jsonschema = { git = "https://github.com/fominok/jsonschema-rs", branch = "feat-unevaluated-properties", default-features = false, features = [
"draft202012",
] }
lazy_static = { version = "1.4" }
log = { version = "0.4" }
num_enum = "0.5.7"
bincode = { version="2.0.0-rc.3", features=["serde"] }
bincode = { version = "2.0.0-rc.3", features = ["serde"] }
rand = { version = "0.8.4", features = ["small_rng"] }
regex = { version="1.5"}
serde = { version="1.0.152", features=["derive"]}
regex = { version = "1.5" }
serde = { version = "1.0.152", features = ["derive"] }
serde-big-array = "0.4.1"
serde_cbor = "0.11.2"
serde_json = { version="1.0", features=["preserve_order"]}
serde_json = { version = "1.0", features = ["preserve_order"] }
serde_repr = { version = "0.1.7" }
sha2 = { version="0.10"}
thiserror = { version = "1.0"}
mockall = { version="0.11.3", optional=true}
sha2 = { version = "0.10" }
thiserror = { version = "1.0" }
mockall = { version = "0.11.3", optional = true }
data-contracts = { path = "../data-contracts" }
platform-value = { path = "../rs-platform-value" }
derive_more = "0.99.17"

[dev-dependencies]
test-case = { version ="2.0"}
tokio = { version ="1.17", features=["full"]}
pretty_assertions = { version="1.3.0"}
test-case = { version = "2.0" }
tokio = { version = "1.17", features = ["full"] }
pretty_assertions = { version = "1.3.0" }

[features]
default = ["fixtures-and-mocks"]
Expand Down
2 changes: 2 additions & 0 deletions packages/rs-drive-abci/.env.example
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,5 @@ TENDERDASH_P2P_PORT=26656

QUORUM_SIZE=5
QUORUM_TYPE=llmq_25_67
CHAIN_ID=devnet
BLOCK_SPACING_MS=3000
15 changes: 12 additions & 3 deletions packages/rs-drive-abci/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,24 @@ tracing-subscriber = { version = "0.3.16", default-features = false, features =
"ansi",
], optional = true }
atty = { version = "0.2.14", optional = true }
tenderdash-abci = { git = "https://github.com/dashpay/rs-tenderdash-abci", branch = "master", optional = true }
# tenderdash-abci = { path = "/home/lklimek/git/lklimek/tenderdash-abci-rs/abci", optional = true }
tenderdash-abci = { git = "https://github.com/dashpay/rs-tenderdash-abci", optional = true }
# tenderdash-abci = { path = "../../../rs-tenderdash-abci/abci", optional = true }
anyhow = { version = "1.0.70" }
lazy_static = "1.4.0"
itertools = { version = "0.10.5" }

[dev-dependencies]

[features]
default = ["server"]
server = ["tenderdash-abci", "clap", "dotenvy", "tracing-subscriber", "atty", "mockall"]
server = [
"tenderdash-abci",
"clap",
"dotenvy",
"tracing-subscriber",
"atty",
"mockall",
]

[[bin]]
name = "drive-abci"
Expand Down
Loading