-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: feat: use shape touched information in necessary columns optimization #368
draft: feat: use shape touched information in necessary columns optimization #368
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 93.81% 93.89% +0.07%
==========================================
Files 23 23
Lines 2925 2930 +5
==========================================
+ Hits 2744 2751 +7
+ Misses 181 179 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@agoose77 so far this is just the start of some code to be able to pass Does this sound reasonable? |
layers[name] = layers[name].project_columns(neccols) | ||
layers[name] = layers[name].project_columns( | ||
neccols, | ||
necessary_shape_columns=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this None
can be replaced by TypeTracerReport.shape_touched
cc @lgray; if my comment above is the route we take then there will be some required changes in uproot (I'd be happy to help/do it- it should be simple- the function classes like |
that shouldn't be a big issue! |
9e7b806
to
8ad6643
Compare
No description provided.