-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: harden typing in the code base; add pre-commit check; improve docs #383
Merged
douglasdavis
merged 10 commits into
dask-contrib:main
from
douglasdavis:misc-typing-fixes
Oct 12, 2023
Merged
fix: harden typing in the code base; add pre-commit check; improve docs #383
douglasdavis
merged 10 commits into
dask-contrib:main
from
douglasdavis:misc-typing-fixes
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
reviewed
Oct 9, 2023
agoose77
reviewed
Oct 9, 2023
agoose77
reviewed
Oct 9, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #383 +/- ##
==========================================
- Coverage 93.21% 92.50% -0.72%
==========================================
Files 24 24
Lines 3038 3043 +5
==========================================
- Hits 2832 2815 -17
- Misses 206 228 +22
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Angus Hollands <goosey15@gmail.com>
douglasdavis
force-pushed
the
misc-typing-fixes
branch
from
October 11, 2023 15:59
998353f
to
3d68678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we've always had type hints throughout dask-awkward but it's never been formalized, this PR aims to clarify typing in the project.