Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump Python use of 3.10 to 3.11 in CI; drop Python 3.8 #388

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

douglasdavis
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Merging #388 (734c489) into main (a1b24fc) will decrease coverage by 0.04%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   92.50%   92.47%   -0.04%     
==========================================
  Files          24       24              
  Lines        3043     3043              
==========================================
- Hits         2815     2814       -1     
- Misses        228      229       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglasdavis douglasdavis merged commit e8ecc29 into dask-contrib:main Oct 16, 2023
19 checks passed
@douglasdavis douglasdavis deleted the ci-and-drop-python-38 branch October 16, 2023 18:17
@agoose77
Copy link
Collaborator

As a maintainer, I'm in favour of this, However, Scientific Python is more aggressive with Python versions than e.g. Awkward Array is at the moment. @lgray are there any experiment restrictions on Python versions that would warrant us reverting this PR?

@lgray
Copy link
Collaborator

lgray commented Oct 16, 2023

python 3.8 is all of our present images, is in common CMSSW releases, and allowed by coffea (since people use coffea in all these combinations of software). Because of this I was planning to follow the standard python 3.8 end of life later in 2024.

We do have python 3.10 images coming out now, and I'm relatively happy so long as a functioning version of dask-awkward is available python 3.8... I'd prefer to have bugfixes available there for a while though.

@lgray
Copy link
Collaborator

lgray commented Oct 16, 2023

Actually - yes @douglasdavis please revert the part of this where we drop python 3.8. We will certainly find bugs as we release this for more users to try, and there's going to be a good portion of them effectively stuck with python 3.8 for one reason or another.

@douglasdavis
Copy link
Collaborator Author

OK sounds good, I mistakenly thought awkward-array followed Scientific Python versioning, apologies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants