feat: deprecate opt_touch_all from map_partitions.
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasdavis
force-pushed
the
remove-opt-touch-all-from-map-partitions
branch
from
05d36d1 to
3765caa
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
- Coverage 93.82% 93.76% -0.06%
==========================================
Files 23 23
Lines 3158 3144 -14
==========================================
- Hits 2963 2948 -15
- Misses 195 196 +1 ☔ View full report in Codecov by Sentry. |
douglasdavis
changed the title
opt_touch_all from map_parititions.opt_touch_all from map_parititions.
douglasdavis
force-pushed
the
remove-opt-touch-all-from-map-partitions
branch
from
3765caa to
663bc5f
Compare
douglasdavis
force-pushed
the
remove-opt-touch-all-from-map-partitions
branch
from
663bc5f to
dbb4f74
Compare
douglasdavis
force-pushed
the
remove-opt-touch-all-from-map-partitions
branch
from
dbb4f74 to
cd3b51c
Compare
douglasdavis
force-pushed
the
remove-opt-touch-all-from-map-partitions
branch
from
cd3b51c to
c11b57b
Compare
|
@lgray can we merge this and bump coffea? |
agoose77
changed the title
opt_touch_all from map_parititions.opt_touch_all from map_partitions.
|
@lgray has given this the green light! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
opt_touch_allargument tomap_partitionswas added to make layers manually touchable (that is, tell the optimization code to not rely on the typetracer graph for touching in that layer, just touch all awkward data at that point). This allowed us to workaround operations where automatic typetracer touching wasn't working.It was only used with
dak.zip, but with the work on upstream typetracer and the optimization refactor here in dask-awkward, I think we're in a place now where we don't need it.It's currently used in coffea, see: scikit-hep/coffea#915