-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Delayed
in partitionwise layer creation.
#449
feat: add support for Delayed
in partitionwise layer creation.
#449
Conversation
Broadcasting will equivalently at each partition because the Delayed object is *not* partitioned.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
+ Coverage 93.09% 93.10% +0.01%
==========================================
Files 23 23
Lines 3272 3279 +7
==========================================
+ Hits 3046 3053 +7
Misses 226 226 ☔ View full report in Codecov by Sentry. |
Cool, I'll give it a try in the morning! |
I'm getting an odd error when I try to print out the dask awkward array that's made from something using delayed:
I haven't traced it to understand why the output dak array things it's a dask.delayed? |
It's probably that something's constructed |
Is it possible to get a repro for that
|
I'll see if I can get one - I'm trying to make sure first I'm not bamboozling myself. |
somehow array.divisions has, itself, become a delayed object!? |
Just to jot this information down in a more permanent place: we discovered during slack conversation that if a |
easy to fix, right? |
Yes! fixed in 9c6a65b |
Broadcasting will occur equivalently at each partition because the Delayed object is not partitioned (as shown in the test added in this PR).