-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: go direct to _map_partitions in functions that receive already flat deps #558
base: main
Are you sure you want to change the base?
Conversation
I suppose we need a dask version pin or wait for the Task stuff? |
I thought of something even better for this. I think I just want to change |
cool old tests pass. I'll devise a test to make sure it is doing what I expect. |
for more information, see https://pre-commit.ci
d0f41d1
to
be4e7ba
Compare
so this is ready to go except for the fact it uncovered a bug in fuse linear chains. it does not respect kwargs for the older dask versions. |
Make that a separate issue and merge this? |
I'd have to back out the change that allows non-collection kwargs to pass through if I didn't fix that issue. |
But I do agree it's probably better to factor. |
Justification: if the dependencies are already flat there's no need to unpack them.