Skip to content

Commit

Permalink
Rename get_default_shuffle_algorithm to get_default_shuffle_method (
Browse files Browse the repository at this point in the history
#7902)

Co-authored-by: James Bourbeau <jrbourbeau@gmail.com>
  • Loading branch information
hendrikmakait and jrbourbeau authored Jun 13, 2023
1 parent aca7c02 commit 1462479
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 16 deletions.
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,6 @@ repos:
- pytest
- tornado
- pyarrow
- git+https://github.com/dask/dask
# - git+https://github.com/dask/dask
- git+https://github.com/hendrikmakait/dask.git@default-shuffle-ignores-fuse
- git+https://github.com/dask/zict
7 changes: 4 additions & 3 deletions continuous_integration/gpuci/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,13 @@ gpuci_logger "Activate conda env"
. /opt/conda/etc/profile.d/conda.sh
conda activate dask

gpuci_logger "Install dask"
python -m pip install git+https://github.com/dask/dask

gpuci_logger "Install distributed"
python -m pip install -e .

gpuci_logger "Install dask"
# python -m pip install git+https://github.com/dask/dask
python -m pip install git+https://github.com/hendrikmakait/dask.git@default-shuffle-ignores-fuse

gpuci_logger "Check Python versions"
python --version

Expand Down
19 changes: 7 additions & 12 deletions distributed/tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,7 @@
import dask.bag as db
from dask import delayed
from dask.optimization import SubgraphCallable
from dask.utils import (
get_default_shuffle_algorithm,
parse_timedelta,
stringify,
tmpfile,
)
from dask.utils import get_default_shuffle_method, parse_timedelta, stringify, tmpfile

from distributed import (
CancelledError,
Expand Down Expand Up @@ -3229,25 +3224,25 @@ def test_default_get(loop_in_thread):
# These may change in the future but the selection below should not
distributed_default = "p2p" if has_pyarrow else "tasks"
local_default = "disk"
assert get_default_shuffle_algorithm() == local_default
assert get_default_shuffle_method() == local_default
with Client(s["address"], set_as_default=True, loop=loop) as c:
assert dask.base.get_scheduler() == c.get
assert get_default_shuffle_algorithm() == distributed_default
assert get_default_shuffle_method() == distributed_default

assert dask.base.get_scheduler() == pre_get
assert get_default_shuffle_algorithm() == local_default
assert get_default_shuffle_method() == local_default

c = Client(s["address"], set_as_default=False, loop=loop)
assert dask.base.get_scheduler() == pre_get
assert get_default_shuffle_algorithm() == local_default
assert get_default_shuffle_method() == local_default
c.close()

c = Client(s["address"], set_as_default=True, loop=loop)
assert get_default_shuffle_algorithm() == distributed_default
assert get_default_shuffle_method() == distributed_default
assert dask.base.get_scheduler() == c.get
c.close()
assert dask.base.get_scheduler() == pre_get
assert get_default_shuffle_algorithm() == local_default
assert get_default_shuffle_method() == local_default

with Client(s["address"], loop=loop) as c:
assert dask.base.get_scheduler() == c.get
Expand Down

0 comments on commit 1462479

Please sign in to comment.