Support fixtures and pytest.mark.parametrize with gen_cluster
#4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
approved these changes
Jun 23, 2021
|
Test failure seems to be unrelated. Thanks @gjoseph92 |
|
Ooh, nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've often wanted to
@pytest.mark.parametrizetests that use@gen_cluster. The current pattern is to define the main testing logic in a closure within the outer parametrized function (example). This works okay, but it's a little unintuitive. By altering the signature of the wrapped function, we can make it play nicely with pytest.Related to #3540 (if that weren't already closed, I'd say this closes it).
black distributed/flake8 distributed/isort distributed