Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert AMM ReduceReplicas and parallel AMMs updates (#5335)" #5337

Closed
wants to merge 2 commits into from

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Sep 22, 2021

This reverts the revert and adds another commit. The additional commit re-establishes a client+worker message send. This is misleading since the transition system on scheduler side switched to inplace dict mutations and the refactoring dropped these messages. I cannot reason yet how this leads up to our observed deadlock but it is a start.

For reference, I intended to remove this handler entirely in #5091 which outlines a subtle, yet non critical race condition. I believe it will become obsolete with #5046 as well. I will further investigate the code to look for more potential diffs but so far it look good

xref #5335 #5297

@crusaderky
Copy link
Collaborator

crusaderky commented Sep 22, 2021

For the sake of not blocking more than what needs to, I'd suggest retiring this PR and going on with

which, put together, duplicate this PR - except that the first two can be merged in straight away.

@fjetter
Copy link
Member Author

fjetter commented Sep 22, 2021

fine by me

@fjetter fjetter closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants