Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change title for plugins documentation #6733

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Change title for plugins documentation #6733

merged 2 commits into from
Jul 26, 2022

Conversation

scharlottej13
Copy link
Contributor

@scharlottej13 scharlottej13 commented Jul 15, 2022 •
edited
Loading

Closes #6729

  • Tests added / passed
  • Passes pre-commit run --all-files

In addition to changing the title, I also added a few sentences at the top for a summary, and a video snippet that seemed like a relevant example.

cc @jrbourbeau

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 46m 45s ⏱️ + 25m 26s
  2 977 tests ±0    2 887 ✔️ +1       87 💤 ±0  2 ❌  - 1  1 🔥 ±0 
22 072 runs  ±0  21 031 ✔️ ±0  1 037 💤 +1  3 ❌  - 1  1 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 6b9d6ae. ± Comparison against base commit 930d3dc.

jrbourbeau
jrbourbeau reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scharlottej13! Overall this looks great -- just left a few minor comments

docs/source/plugins.rst Outdated Show resolved Hide resolved
docs/source/plugins.rst Outdated Show resolved Hide resolved
docs/source/plugins.rst Outdated Show resolved Hide resolved
@jacobtomlinson @jrbourbeau
Apply suggestions from code review
3eab3f5 
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
jacobtomlinson
jacobtomlinson approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I agree with @jrbourbeau's tweaks so I hope you don't mind but I've committed them.

@jacobtomlinson jacobtomlinson merged commit a53858a into dask:main Jul 26, 2022
@jrbourbeau
Copy link
Member

Thanks @scharlottej13 @jacobtomlinson

@scharlottej13
Copy link
Contributor Author

Thanks @jrbourbeau @jacobtomlinson !

@scharlottej13 scharlottej13 deleted the plugins branch July 26, 2022 15:31
gjoseph92 pushed a commit to gjoseph92/distributed that referenced this pull request Oct 31, 2022
@scharlottej13 @gjoseph92
Change title for plugins documentation (dask#6733)
4691c00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrbourbeau jrbourbeau jrbourbeau left review comments

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc page title is confusing
4 participants
@scharlottej13 @GPUtester @jrbourbeau @jacobtomlinson