Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tornado 6.2 #6991

Closed
wants to merge 4 commits into from
Closed

Support tornado 6.2 #6991

wants to merge 4 commits into from

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Sep 2, 2022 •
edited
Loading

Closes #6669

Looks like all of the deprecations were already dealt with

@fjetter fjetter changed the title Remove pinning of tornado 6.2 Support tornado 6.2 Sep 2, 2022
@fjetter fjetter mentioned this pull request Sep 2, 2022
Closed
5 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 15m 35s ⏱️ - 9m 51s
  3 112 tests ±0    3 014 ✔️  - 12    85 💤 ±0  10 ❌ +  9  3 🔥 +3 
23 034 runs  ±0  22 084 ✔️  - 43  906 💤 ±0  35 ❌ +34  9 🔥 +9 

For more details on these failures and errors, see this check.

Results for commit 950437e. ± Comparison against base commit 17c70e9.

♻️ This comment has been updated with latest results.

@fjetter fjetter mentioned this pull request Sep 2, 2022
Open
jrbourbeau
jrbourbeau reviewed Sep 2, 2022
View reviewed changes
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fjetter! Unfortunately it looks like tornado=6.1 is getting pulled into CI. Maybe there's some other dependency that's putting an upper bound on tornado? Might be worth pinning tornado=6.2 in one of the environment files as a test

continuous_integration/environment-3.10.yaml Outdated Show resolved Hide resolved
@ptrba ptrba mentioned this pull request Sep 22, 2022
Closed
crusaderky
crusaderky reviewed Sep 26, 2022
View reviewed changes
continuous_integration/environment-3.10.yaml
@@ -38,7 +38,7 @@ dependencies:
- sortedcollections
- tblib
- toolz
- tornado<6.2
- tornado=6.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, 6.1 is installed

This was referenced Oct 12, 2022
Closed
Closed
@fjetter
Copy link
Member Author

fjetter commented Nov 24, 2022

superseded by #7286

@fjetter fjetter closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusaderky crusaderky crusaderky left review comments

@jrbourbeau jrbourbeau jrbourbeau left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tornado 6.2 compatibility
3 participants
@fjetter @crusaderky @jrbourbeau