remove deprecated code calls to IOLoop.make_current()
#7240
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 23m 46s ⏱️ + 12m 30s Results for commit 84b32f2. ± Comparison against base commit c137ac0. ♻️ This comment has been updated with latest results. |
graingert
force-pushed
the
remove-deprecated-make-current
branch
from
fa10314
to
90961fb
Compare
it's only used in test_client, and requires calling make_current
graingert
force-pushed
the
remove-deprecated-make-current
branch
from
90961fb
to
84b9384
Compare
| stack.callback(thread.join, timeout=2) | ||
| async with worker: | ||
| failure_type = None | ||
|
|
||
| try: | ||
| assert worker.address | ||
| except ValueError: |
There was a problem hiding this comment.
This is outside of the changes made in this PR, but do you have an idea why the ValueError would pop up here and why it's okay to ignore it?
There was a problem hiding this comment.
it's this ValueError
distributed/distributed/core.py
Line 573 in 041e1c5
There was a problem hiding this comment.
@fjetter: Do you happen to know whether we should keep ignoring this error?
Co-authored-by: Hendrik Makait <hendrik.makait@gmail.com>
move utils_test.pristine_loop into test_client.py - it's only used in test_client, and requires calling make_current
remove
IOLoop.make_current()fromNanny._runrefs #6784
Closes #xxxx
pre-commit run --all-files