Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit Dashboard worker table to page width #8897

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

jacobtomlinson
Copy link
Member

Closes #8648
Also closes dask/dask#10409

Before

image

After

image
  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    24 files   -     1      24 suites   - 1   9h 59m 57s ⏱️ - 14m 54s
 4 130 tests ±    0   4 016 ✅ +    3    110 💤 ±  0  4 ❌  - 3 
46 298 runs   - 1 410  44 355 ✅  - 1 250  1 938 💤  - 158  5 ❌  - 2 

For more details on these failures, see this check.

Results for commit 30fec1a. ± Comparison against base commit c3482ee.

@hendrikmakait
Copy link
Member

Should we enforce a minimum width?

@jacobtomlinson
Copy link
Member Author

I don't think we need to. There is a minimum width on the page already.

If you make the page really narrow things get a bit squashed up again, but they do for all the pages. The dashboard isn't really designed to work on phones and things.

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jacobtomlinson!

@hendrikmakait hendrikmakait merged commit 276fc35 into dask:main Oct 16, 2024
24 of 33 checks passed
@jacobtomlinson jacobtomlinson deleted the worker-table-fit branch October 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants