Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recursion in task spec #8920

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Oct 31, 2024

See

The most important PR to review is the dask/dask one.

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  ±0      25 suites  ±0   10h 23m 10s ⏱️ + 2m 41s
 4 130 tests ±0   4 016 ✅ ±0    110 💤 ±0  4 ❌ ±0 
47 692 runs  ±0  45 565 ✅  - 1  2 122 💤 +1  5 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4d6826a. ± Comparison against base commit d7eff77.

♻️ This comment has been updated with latest results.

@fjetter fjetter force-pushed the task_spec_remove_recursion branch from 8293696 to 32e1349 Compare November 4, 2024 10:33
Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2P currently imports _inline_recursively which has been removed. (See CI failure: distributed/shuffle/_core.py:28: error: Module "dask._task_spec" has no attribute "_inline_recursively"; maybe "_call_recursively"? [attr-defined])

EDIT: Ignore the above, we've run into a review race condition.

@fjetter
Copy link
Member Author

fjetter commented Nov 4, 2024

EDIT: Ignore the above, we've run into a review race condition.

Yeah, I'm still working on CI. The gist of the changes will very likely remain the same so I encourage a review regardless of bad CI

@fjetter fjetter force-pushed the task_spec_remove_recursion branch 4 times, most recently from 0c1c99c to f30fd2d Compare November 14, 2024 14:18
@fjetter fjetter force-pushed the task_spec_remove_recursion branch from 4d6826a to 4e62393 Compare November 19, 2024 13:05
@fjetter fjetter merged commit 750cb91 into dask:main Nov 19, 2024
10 of 28 checks passed
@fjetter fjetter deleted the task_spec_remove_recursion branch November 19, 2024 13:07
@jrbourbeau jrbourbeau mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants