Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pynvml>=11.5 in WSL #8962

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Support pynvml>=11.5 in WSL #8962

merged 3 commits into from
Dec 11, 2024

Conversation

rjzamora
Copy link
Member

Closes #8961

Handles the case that pynvml.nvmlSystemGetDriverVersion() returns str instead of bytes.

@rjzamora rjzamora self-assigned this Dec 11, 2024
@rjzamora rjzamora added bug Something is broken diagnostics gpu labels Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±0      29 suites  ±0   12h 19m 25s ⏱️ - 9m 40s
 4 130 tests ±0   4 016 ✅ +3    111 💤 ±0  3 ❌  - 2 
55 839 runs   - 1  53 408 ✅ +3  2 426 💤  - 1  5 ❌  - 2 

For more details on these failures, see this check.

Results for commit b004b1f. ± Comparison against base commit 6eabc90.

jakirkham
jakirkham reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rick! 🙏

Had a simplifying suggestion below

distributed/diagnostics/nvml.py Outdated Show resolved Hide resolved
distributed/diagnostics/nvml.py Outdated Show resolved Hide resolved
@rjzamora rjzamora mentioned this pull request Dec 11, 2024
Closed
jacobtomlinson
jacobtomlinson approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjzamora

@jacobtomlinson jacobtomlinson merged commit 3ef88b3 into dask:main Dec 11, 2024
26 of 32 checks passed
@rjzamora rjzamora deleted the fix-pynvml-decode branch December 11, 2024 14:51
jrbourbeau
jrbourbeau reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjzamora @jakirkham @jacobtomlinson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrbourbeau jrbourbeau jrbourbeau left review comments

@jakirkham jakirkham jakirkham left review comments

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

@quasiben quasiben Awaiting requested review from quasiben quasiben is a code owner

Assignees

@rjzamora rjzamora

Labels
bug Something is broken diagnostics gpu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyNVML error on WSL
4 participants
@rjzamora @jacobtomlinson @jakirkham @jrbourbeau