Add prompt and dat.json to dat create #765
Conversation
src/commands/create.js
Outdated
| } | ||
| } | ||
| prompt.message = chalk.green('> ') | ||
| prompt.delimiter = '' // chalk.cyan('') |
There was a problem hiding this comment.
maybe : would be better to read?
There was a problem hiding this comment.
Unfortunately it adds a delimiter after the message and after the description:
(In this case, I have My dataset in dat.json already, so it defaults to that).
I could change the message to something that'd make more sense with a delimiter.
src/commands/create.js
Outdated
| prompt.get(schema, writeDatJson) | ||
|
|
||
| function writeDatJson (err, results) { | ||
| if (err) return console.log(err.message) // prompt error |
There was a problem hiding this comment.
this should exit with code 1 too
There was a problem hiding this comment.
would the bus.emit('exit:error', err) do that?
There was a problem hiding this comment.
Yes! At first I thought this may be prompt errors, e.g. if you get something that doesn't match the required pattern, but I think that is handled differently.
would the bus.emit('exit:error', err) do that?
yep
src/ui/create.js
Outdated
| var progressView | ||
| var exitMsg = ` | ||
| Your dat is created! Run ${chalk.green('dat sync')} to share: | ||
| ${chalk.blue('dat://' + stringKey(dat.key))} |
There was a problem hiding this comment.
template literals all the way?
${chalk.blue(`dat://${stringKey(dat.key)}`)}I know it can look confusing to nest them, but it's also weird to mix two concepts that can do the same.
There was a problem hiding this comment.
Ha ya, I'm gonna make the key a ui/element along with pluralize. Just got a bit lazy last night.
src/ui/create.js
Outdated
| ${state.exiting ? exitMsg : chalk.dim('Ctrl+C to Exit')} | ||
| ` | ||
|
|
||
| function pluralize (str, val) { |
There was a problem hiding this comment.
this function has been defined twice in this patch, maybe we want to move it to lib/ or source a simple one from npm?
With this PR
dat createwill now:With Importing example:
Not importing example: