Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bandwidth throttling #806

Merged
merged 3 commits into from
Jun 16, 2017
Merged

add bandwidth throttling #806

merged 3 commits into from
Jun 16, 2017

Conversation

juliangruber
Copy link
Collaborator

No description provided.

@mafintosh
Copy link
Contributor

Looks good except it doesn't seem to work if I pass 14kb/s but only work if I pass 14kb.

joehand
joehand approved these changes Jun 15, 2017
View reviewed changes
Copy link
Collaborator

@joehand joehand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you add the expected syntax to the help text?

@juliangruber
Copy link
Collaborator Author

updated

@joehand joehand merged commit 18e62cf into master Jun 16, 2017
@joehand joehand deleted the add/throttle branch June 16, 2017 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehand joehand joehand approved these changes

Assignees
No one assigned
Labels
Priority: High Status: Review Needed Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliangruber @mafintosh @joehand