Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show messsage if invalid dir name on createDir #889

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

tgfjt
Copy link
Contributor

@tgfjt tgfjt commented Oct 31, 2017

Hi, Dat people!

I saw an error with wrong argument to clone sample.
How do you like to show a message to get valid argument?

$ dat clone dat://xxxx 2017
fs.js:288
  binding.access(pathModule._makeLong(path), mode, req);
          ^

TypeError: path must be a string or Buffer
    at Object.fs.access (fs.js:288:11)
    at createDir (/Users/tgfjt/workspace/dat/src/commands/clone.js:95:10)
    at /Users/tgfjt/workspace/dat/src/commands/clone.js:84:7
    at /Users/tgfjt/workspace/dat/node_modules/dat-link-resolve/index.js:34:23
    at /Users/tgfjt/workspace/dat/node_modules/call-me-maybe/index.js:11:28
    at _combinedTickCallback (internal/process/next_tick.js:95:7)
    at process._tickCallback (internal/process/next_tick.js:161:9)
    at Function.Module.runMain (module.js:607:11)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:575:3

Copy link

@martinheidegger martinheidegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - The build errors might be fixed by re-running the travis build

@joehand joehand merged commit ba5e34a into dat-ecosystem:master Mar 27, 2018
@joehand
Copy link
Collaborator

joehand commented Mar 27, 2018

Thanks for fixing it and you patience =)

@tgfjt tgfjt deleted the feature/error-createdir-number branch March 28, 2018 01:00
@tgfjt
Copy link
Contributor Author

tgfjt commented Mar 28, 2018

thanks, hooray! 🎉

max-mapper pushed a commit that referenced this pull request Apr 12, 2018
* show messsage if invalid dir name on createDir

* change or to and, fix tests
joehand pushed a commit that referenced this pull request Apr 12, 2018
* add download script

* fix tests, pin standard

* #930 replaced / with path.sep (#962)

* add latest to travis

* show messsage if invalid dir name on createDir (#889)

* show messsage if invalid dir name on createDir

* change or to and, fix tests

* Create issue_template.md (#972)

* Create issue_template.md

* Comment out security issue

* Add more comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants