Update read_table #362
Merged
Update read_table #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So far this looks like there's actually no problems - @davidwagner if you could please test against more dense/heavier data files, that'd be great! I have a sinking feeling that something's off here, but I can't tell what and it works 100% (at least locally). Maybe I'm just being paranoid. |
adnanhemani
force-pushed
the
updae_read_table
branch
from
3eaae2c to
997e850
Compare
|
I tested on a few csv files I have lying around, including the large one used in my privacy lecture and some ones that trigger Unicode errors, and the behavior before vs after was identical in all cases. So this seems fine as far as all my testing indicates. |
davidwagner
approved these changes
Jun 11, 2019
This was referenced Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[X] Wrote test for feature
[N/A] Added changes in the Changelog section in README.md
[N/A] Bumped version number (delete if unneeded)
Changes proposed:
Used the solution in #353 and added more robust testing. Thank you @deculler!