Implement EqualityMapping and use for relevant dtype helpers
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
asmeurer
reviewed
Apr 13, 2022
Drops internal use of hashing via dicts for dtype helpers
|
I'll merge this tomorrow unless any blockers are identified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #111 by implementing a dict-like class
EqualityMappingthat uses equality for indexing, as opposed to hashing.The test suite would work again with NumPy-proper, except another issue now persists if you use newer versions of Hypothesis (specifically after HypothesisWorks/hypothesis#3156)—an internal check assumes floats are being returned for
xp.finfo(), which is not the case with NumPy-proper and so an unrelated error occurs for any test usingxps.from_dtype()... so any test usingxps.arrays()😅 I wrote a quick hack which now bypasses this internal check in__init__.py)... it's certainly not ideal, along with my originalst.floats()monkey patching, so will mull it over.