Fix linalg.trace test, result dtype was incorrect #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the spec says, the output dtype should be the default integer/float/complex dtype just like for `sum`. Given that the reference was implemented with `sum`, avoiding to pass an explicit dtype should be enough to obtain the correct results.
honno
force-pushed
the
fix-linalg-trace-test
branch
from
bf73702
to
d35ee58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the spec says, the output dtype should be the default integer/float/complex dtype just like for
sum. Given that the reference was implemented withsum, avoiding to pass an explicit dtype should be enough to obtain the correct results.