Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing subscripts in sign definition #844

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

mdhaber
Copy link
Contributor

@mdhaber mdhaber commented Sep 21, 2024

Looked like these subscripts were omitted.

LMK if this should be adjusted in 2012/2013 standards, but I think the intent is obvious enough that it doesn't need to be fixed in old versions.

@kgryte kgryte changed the title Add subscript in sign definition docs: add missing subscripts in sign definition Sep 21, 2024
@kgryte kgryte added this to the v2024 milestone Sep 21, 2024
@kgryte kgryte added Maintenance Bug fix, typo fix, or general maintenance. Narrative Content Narrative documentation content. Backport Changes involve backporting to previous versions. labels Sep 21, 2024
@kgryte
Copy link
Contributor

kgryte commented Sep 21, 2024

Thanks for flagging this. Yes, if you wouldn't mind backporting to previous spec versions, that would be helpful.

@mdhaber
Copy link
Contributor Author

mdhaber commented Oct 16, 2024

Thanks @kgryte. I've added the subscripts to past versions, too.

Copy link
Contributor

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @mdhaber!

@kgryte kgryte merged commit 1765933 into data-apis:main Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Changes involve backporting to previous versions. Maintenance Bug fix, typo fix, or general maintenance. Narrative Content Narrative documentation content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants