add contributing.md

README.md

@@ -45,31 +45,3 @@ Installation
 ```
 pip install dataframe-api-compat
 ```
-
-Testing
--------
-```
-pytest test_standard.py --cov=dataframe_api_compat --cov=test_standard --cov-fail-under=100
-```
-100% branch coverage isn't the objective - it's the bare minimum.
-
-Linting
--------
-```
-pre-commit run --all-files
-```
-
-Type Checking
--------------
-
-First, clone the [dataframe_standard](https://github.com/data-apis/dataframe-api) to some
-local path. Then, run:
-```console
-MYPYPATH=<path to dataframe-api/spec/API_specification> mypy dataframe_api_compat
-MYPYPATH=<path to dataframe-api/spec/API_specification> mypy polars_standard.py
-```
-
-For example, if you cloned both repos in the same place, this could be:
-```console
-MYPYPATH=../dataframe-api/spec/API_specification/ mypy dataframe_api_compat
-```

contributing.md

@@ -0,0 +1,35 @@
+Installation
+------------
+```
+python3.10 -m venv .venv
+. .venv/bin/activate
+pip install -U pip wheel
+pip install -r requirements-dev.txt
+```
+Testing
+-------
+```
+pytest test_standard.py --cov=dataframe_api_compat --cov=test_standard --cov-fail-under=100
+```
+100% branch coverage isn't the objective - it's the bare minimum.
+
+Linting
+-------
+```
+pre-commit run --all-files
+```
+
+Type Checking
+-------------
+
+First, clone the [dataframe_standard](https://github.com/data-apis/dataframe-api) to some
+local path. Then, run:
+```console
+MYPYPATH=<path to dataframe-api/spec/API_specification> mypy dataframe_api_compat
+MYPYPATH=<path to dataframe-api/spec/API_specification> mypy polars_standard.py
+```
+
+For example, if you cloned both repos in the same place, this could be:
+```console
+MYPYPATH=../dataframe-api/spec/API_specification/ mypy dataframe_api_compat
+```

dataframe_api_compat/polars_standard/polars_standard.py

@@ -585,10 +585,10 @@ def all(self, *, skip_nulls: bool = True) -> PolarsDataFrame:
         return PolarsDataFrame(self.dataframe.select(pl.col("*").all()))
 
     def any_rowwise(self, *, skip_nulls: bool = True) -> PolarsColumn[Bool]:
-        return PolarsColumn(self.dataframe.select(pl.any(pl.col("*")))["any"])
+        return PolarsColumn(self.dataframe.select(pl.any_horizontal(pl.col("*")))["any"])
 
     def all_rowwise(self, *, skip_nulls: bool = True) -> PolarsColumn[Bool]:
-        return PolarsColumn(self.dataframe.select(pl.all(pl.col("*")))["all"])
+        return PolarsColumn(self.dataframe.select(pl.all_horizontal(pl.col("*")))["all"])
 
     def min(self, *, skip_nulls: bool = True) -> PolarsDataFrame:
         return PolarsDataFrame(self.dataframe.select(pl.col("*").min()))

make.sh

@@ -1,2 +1,2 @@
 . type-check.sh
-pytest tests --cov=dataframe_api_compat --cov=tests --cov-fail-under=100
+pytest tests --cov=dataframe_api_compat --cov=tests --cov-fail-under=100 -W error

requirements-dev.txt

@@ -1,6 +1,7 @@
 covdefaults
 pandas
 polars
+pre-commit
 pyarrow
 pytest
 pytest-cov