Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix street queries to contain street2 #2490

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix street queries to contain street2 #2490

merged 1 commit into from
Oct 4, 2023

Conversation

atalyaalon
Copy link
Collaborator

No description provided.

@atalyaalon atalyaalon requested a review from ziv17 October 4, 2023 17:00
@atalyaalon
Copy link
Collaborator Author

atalyaalon commented Oct 4, 2023

@ziv17 FYI - it seems like we have in location_info both street1 and street1_hebrew, and they are both filtered when querying a specific street, hence @BarVolunteering 's fix here was not enough to add street2 data, but this does the job.

Maybe we'll want to standardize all queries with street number only? Let me know what you think, I'm merging this in the meanwhile

@atalyaalon
Copy link
Collaborator Author

atalyaalon commented Oct 4, 2023

@MichalOren FYI - adding street2 data (data will update after cache will run at the beginning of next week (by Monday probably)

@atalyaalon atalyaalon merged commit 5d5c39c into dev Oct 4, 2023
3 checks passed
@atalyaalon atalyaalon deleted the fix-street-queries branch October 4, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant