-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2373- move widgets to all locations #2512
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #2512 +/- ##
==========================================
+ Coverage 52.98% 53.26% +0.28%
==========================================
Files 117 117
Lines 9645 9679 +34
==========================================
+ Hits 5110 5156 +46
+ Misses 4535 4523 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@EliorGigi great! Can you fix black (see this - can be executed in anyway container) and pylint issues? (you can see details here |
Changes Made
Moved the following widgets from
road_segment_widgets
toall_location_widgets
:killed_and_injured_count_per_age_group
killed_and_injured_count_per_age_group_stacked
injured_count_by_severity
Fixed the
/api/infographics-data
endpoint'snews_flash_id
argument (reflects the update in the Swagger documentation).Resolved a bug in the histogram within the
killed_and_injured_count_per_age_group
widget. Previously, when there were no accidents with the "unknown" type, the widgets crashed. This issue can be observed in the production logs. For instance, the following API call was successful:However, the same API call with a 3-year parameter instead of 5 resulted in a crash:
The issue arises when there are no accidents with an "unknown" type within the last 3 years, as all the accident ages are known during that period.