Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOCKER.md #2559

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Update DOCKER.md #2559

merged 3 commits into from
Oct 20, 2024

Conversation

GilMich
Copy link
Contributor

@GilMich GilMich commented Jan 23, 2024

added a little refinement to the installation guide as requested

added a little refinement to the installation guide as requested
@GilMich GilMich closed this Jan 23, 2024
@GilMich GilMich reopened this Jan 23, 2024
@atalyaalon
Copy link
Collaborator

@GilMich are you sure that given WSL you need to install Docker on Windows?

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.89%. Comparing base (c0242b4) to head (ececb6e).
Report is 256 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2559      +/-   ##
==========================================
- Coverage   53.00%   52.89%   -0.12%     
==========================================
  Files         119      122       +3     
  Lines        9804    10147     +343     
==========================================
+ Hits         5197     5367     +170     
- Misses       4607     4780     +173     
Flag Coverage Δ
unittests 52.89% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atalyaalon atalyaalon closed this Oct 20, 2024
@atalyaalon atalyaalon reopened this Oct 20, 2024
@atalyaalon atalyaalon merged commit eb450ba into data-for-change:dev Oct 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants