Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 404 if building request params failed. #2746

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Dec 20, 2024

closes #2736

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.63%. Comparing base (400af13) to head (7c5f622).
Report is 146 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/request_params.py 77.14% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2746      +/-   ##
==========================================
- Coverage   53.22%   52.63%   -0.59%     
==========================================
  Files         119      122       +3     
  Lines        9924    10213     +289     
==========================================
+ Hits         5282     5376      +94     
- Misses       4642     4837     +195     
Flag Coverage Δ
unittests 52.63% <78.37%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziv17 ziv17 marked this pull request as ready for review December 20, 2024 05:40
@ziv17 ziv17 requested a review from atalyaalon December 20, 2024 05:40
@atalyaalon atalyaalon merged commit 9f277f3 into data-for-change:dev Dec 20, 2024
3 checks passed
@atalyaalon
Copy link
Collaborator

@ziv17 great work, thanks for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Internal Server Error from data-infographics API
3 participants